<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Make demo extensible for other type of annotations" href="https://bugs.freedesktop.org/show_bug.cgi?id=69978#c23">Comment # 23</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Make demo extensible for other type of annotations" href="https://bugs.freedesktop.org/show_bug.cgi?id=69978">bug 69978</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>Comment on <a href="attachment.cgi?id=87142" name="attach_87142" title="glib: Add annotations interactively in demo">attachment 87142</a> <a href="attachment.cgi?id=87142&action=edit" title="glib: Add annotations interactively in demo">[details]</a> <a href='page.cgi?id=splinter.html&bug=69978&attachment=87142'>[review]</a> glib: Add annotations interactively in demo Review of <a href="attachment.cgi?id=87142" name="attach_87142" title="glib: Add annotations interactively in demo">attachment 87142</a> <a href="attachment.cgi?id=87142&action=edit" title="glib: Add annotations interactively in demo">[details]</a> <a href='page.cgi?id=splinter.html&bug=69978&attachment=87142'>[review]</a>: ----------------------------------------------------------------- I like the removal of the dialog to add an annotation, but it's a bit weird that while you change the combo to select and annotation, every click on the view adds a new one. I prefer to keep a combo with only the annots types and a button to add annot, similar to render demo. Also I would change the cursor to make it obvious that you are in adding an annot mode. Note also that the original idea of using a dialog was to add more annots properties when adding a new one, allowing you to select the color, or the icon in case of text annots, etc. I guess we can make annots properties editable instead, so that you can change the props multiple times after the annot has been created.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>