<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Make demo extensible for other type of annotations" href="https://bugs.freedesktop.org/show_bug.cgi?id=69978#c21">Comment # 21</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Make demo extensible for other type of annotations" href="https://bugs.freedesktop.org/show_bug.cgi?id=69978">bug 69978</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>Comment on <a href="attachment.cgi?id=87141" name="attach_87141" title="glib: Make the Remove annotation button prominent in demo">attachment 87141</a> <a href="attachment.cgi?id=87141&action=edit" title="glib: Make the Remove annotation button prominent in demo">[details]</a> <a href='page.cgi?id=splinter.html&bug=69978&attachment=87141'>[review]</a> glib: Make the Remove annotation button prominent in demo Review of <a href="attachment.cgi?id=87141" name="attach_87141" title="glib: Make the Remove annotation button prominent in demo">attachment 87141</a> <a href="attachment.cgi?id=87141&action=edit" title="glib: Make the Remove annotation button prominent in demo">[details]</a> <a href='page.cgi?id=splinter.html&bug=69978&attachment=87141'>[review]</a>: ----------------------------------------------------------------- ::: glib/demo/annots.c @@ +959,4 @@ > gtk_widget_show (label); > g_free (str); > > + button = gtk_button_new_from_stock (GTK_STOCK_REMOVE); If we move this close to the Add Annotation button, I would label this one as Remove Annotation or Delete Annotation. Also note that the button was only present in the annotation properties section, so it was obvious which annotation was going to be removed. I would disable the button when there no annotation selected.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>