<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Add support for TextMarkup Annotations in glib frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=51487#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Add support for TextMarkup Annotations in glib frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=51487">bug 51487</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=88272" name="attach_88272" title="glib-demo: Add support for PopplerTextAnnotMarkup">attachment 88272</a> <a href="attachment.cgi?id=88272&action=edit" title="glib-demo: Add support for PopplerTextAnnotMarkup">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=51487&attachment=88272'>[review]</a>
glib-demo: Add support for PopplerTextAnnotMarkup
Review of <span class=""><a href="attachment.cgi?id=88272" name="attach_88272" title="glib-demo: Add support for PopplerTextAnnotMarkup">attachment 88272</a> <a href="attachment.cgi?id=88272&action=edit" title="glib-demo: Add support for PopplerTextAnnotMarkup">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=51487&attachment=88272'>[review]</a>:
-----------------------------------------------------------------
::: glib/poppler-annot.cc
@@ +202,4 @@
<span class="quote">> {
> }
>
> +/* PopplerRectangle type */</span >
Wrong comment
@@ +203,5 @@
<span class="quote">> }
>
> +/* PopplerRectangle type */
> +
> +POPPLER_DEFINE_BOXED_TYPE (PopplerAnnotQuadrilateral, poppler_annot_quadrilateral,</span >
I think this could be PopplerQuadrilateral, this is very generic boxed type
even if it's only used by annots.
@@ +214,5 @@
<span class="quote">> + * Creates a new #PopplerAnnotQuadrilateral. It must be freed with poppler_annot_quadrilateral_free() after use.
> + *
> + * Returns: a new #PopplerAnnotQuadrilateral.
> + *
> + * Since: 0.25</span >
0.26
@@ +217,5 @@
<span class="quote">> + *
> + * Since: 0.25
> + **/
> +PopplerAnnotQuadrilateral *
> +poppler_annot_quadrilateral_new (void)</span >
I think the constructor should receive the points.
::: glib/poppler-annot.h
@@ +226,5 @@
<span class="quote">> + gdouble y2;
> + gdouble x3;
> + gdouble y3;
> + gdouble x4;
> + gdouble y4;</span >
If we had PopplerPoint or PopplerVertex we could use it here too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>