<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821#c28">Comment # 28</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821">bug 64821</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=86685" name="attach_86685" title="[PATCH v8 12/15] glib: Accessors for form fields of structure elements">attachment 86685</a> <a href="attachment.cgi?id=86685&action=edit" title="[PATCH v8 12/15] glib: Accessors for form fields of structure elements">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=86685'>[review]</a>
[PATCH v8 12/15] glib: Accessors for form fields of structure elements
Review of <span class=""><a href="attachment.cgi?id=86685" name="attach_86685" title="[PATCH v8 12/15] glib: Accessors for form fields of structure elements">attachment 86685</a> <a href="attachment.cgi?id=86685&action=edit" title="[PATCH v8 12/15] glib: Accessors for form fields of structure elements">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=86685'>[review]</a>:
-----------------------------------------------------------------
New public symbols should be added to the sections.txt file
::: glib/poppler-structure-element.cc
@@ +859,5 @@
<span class="quote">> +
> +/**
> + * poppler_structure_element_get_form_field:
> + * @poppler_structure_element: A #PopplerStructureElement
> + *</span >
You should add a brief explanation here.
@@ +862,5 @@
<span class="quote">> + * @poppler_structure_element: A #PopplerStructureElement
> + *
> + * Return value: (transfer full): A #PopplerFormField, or %NULL if
> + * the element is not a %POPPLER_STRUCTURE_ELEMENT_FORM.
> + */</span >
Since: 0.26.
@@ +880,5 @@
<span class="quote">> + return NULL;
> +
> + gint field_id = -1;
> + const StructElement *child = poppler_structure_element->elem->getElement (0);
> + if (child->isContent ())</span >
You can return early here to simplify the return below.
@@ +896,5 @@
<span class="quote">> +
> + if (field_id < 0)
> + return NULL;
> +
> + return (field_id < 0) ? NULL : poppler_document_get_form_field (poppler_structure_element->document,</span >
You have already returned in the previous if when field_id < 0.
@@ +903,5 @@
<span class="quote">> +
> +/**
> + * poppler_structure_element_get_form_field_mapping:
> + * @poppler_structure_element: a #PopplerStructureElement
> + *</span >
Description.
@@ +906,5 @@
<span class="quote">> + * @poppler_structure_element: a #PopplerStructureElement
> + *
> + * Return value: (transfer full): A #PopplerFormFieldMapping, or %NULL if
> + * the element is not a %POPPLER_STRUCTURE_ELEMENT_FORM
> + */</span >
Since: 0.26
::: glib/poppler-structure-element.h
@@ +118,4 @@
<span class="quote">> gboolean recursive);
> const gchar *poppler_structure_element_get_alt_text (PopplerStructureElement *poppler_structure_element);
> const gchar *poppler_structure_element_get_actual_text (PopplerStructureElement *poppler_structure_element);
> +PopplerFormField *poppler_structure_element_get_form_field (PopplerStructureElement *poppler_structure_element);</span >
This is not correctly indented.
@@ +118,5 @@
<span class="quote">> gboolean recursive);
> const gchar *poppler_structure_element_get_alt_text (PopplerStructureElement *poppler_structure_element);
> const gchar *poppler_structure_element_get_actual_text (PopplerStructureElement *poppler_structure_element);
> +PopplerFormField *poppler_structure_element_get_form_field (PopplerStructureElement *poppler_structure_element);
> +PopplerFormFieldMapping *poppler_structure_element_get_form_field_mapping (PopplerStructureElement *poppler_structure_element);</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>