<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821">bug 64821</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=86683" name="attach_86683" title="[PATCH v8 10/15] glib: Private function _poppler_link_mapping_new_from_form_field()">attachment 86683</a> <a href="attachment.cgi?id=86683&action=edit" title="[PATCH v8 10/15] glib: Private function _poppler_link_mapping_new_from_form_field()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=86683'>[review]</a>
[PATCH v8 10/15] glib: Private function
_poppler_link_mapping_new_from_form_field()
Review of <span class=""><a href="attachment.cgi?id=86683" name="attach_86683" title="[PATCH v8 10/15] glib: Private function _poppler_link_mapping_new_from_form_field()">attachment 86683</a> <a href="attachment.cgi?id=86683&action=edit" title="[PATCH v8 10/15] glib: Private function _poppler_link_mapping_new_from_form_field()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=86683'>[review]</a>:
-----------------------------------------------------------------
::: glib/poppler-page.cc
@@ +1280,5 @@
<span class="quote">> + Page *page;
> +
> + g_assert (POPPLER_IS_FORM_FIELD (form_field));
> + g_assert (page_num >= 0);
> + g_assert (page_num < poppler_document_get_n_pages (form_field->document));</span >
Same comments here, this asserts look a bit too paranoid for me.
@@ +1325,4 @@
<span class="quote">>
> for (i = 0; i < forms->getNumWidgets (); i++) {
> PopplerFormFieldMapping *mapping;
> + PopplerFormField *field = _poppler_form_field_new (page->document,</span >
If you split this too, you can use a single line for _poppler_form_field_new
@@ +1330,3 @@
<span class="quote">>
> + mapping = _poppler_form_field_mapping_new_from_form_field (field,
> + page->index);</span >
Use a single line here too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>