<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add getter and setter for annotation's rectangle"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70901#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add getter and setter for annotation's rectangle"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70901">bug 70901</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=70901#c2">comment #2</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=88161" name="attach_88161" title="glib: Add getter and setter for annotation's rectangle">attachment 88161</a> <a href="attachment.cgi?id=88161&action=edit" title="glib: Add getter and setter for annotation's rectangle">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=70901&attachment=88161'>[review]</a> [review]
> glib: Add getter and setter for annotation's rectangle
>
> Review of <span class="bz_obsolete"><a href="attachment.cgi?id=88161" name="attach_88161" title="glib: Add getter and setter for annotation's rectangle">attachment 88161</a> <a href="attachment.cgi?id=88161&action=edit" title="glib: Add getter and setter for annotation's rectangle">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=70901&attachment=88161'>[review]</a> [review]:
> -----------------------------------------------------------------
>
> ::: glib/poppler-annot.cc
> @@ +719,5 @@
> > + * Since: 0.25
> > + **/
> > +void
> > +poppler_annot_set_rectangle (PopplerAnnot *poppler_annot,
> > + PopplerRectangle poppler_rect)
>
> We still need to call setRect with the coordinates. PopplerRectangle
> (struct) does not map to PDFRectangle (class).</span >
Yes, I mean to use a pointer for the parameter so that the caller can do:
PopplerRectangle rect = { 1, 2, 3, 4 };
poppler_annot_set_rectangle (annot, &rect);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>