<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - glib-demo: Add support for simple line annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70981#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - glib-demo: Add support for simple line annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70981">bug 70981</a>
from <span class="vcard"><a class="email" href="mailto:gpoo@gnome.org" title="Germán Poo-Caamaño <gpoo@gnome.org>"> <span class="fn">Germán Poo-Caamaño</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=70981#c2">comment #2</a>)
<span class="quote">> @@ +1439,5 @@
> > }
> > +
> > +/* PopplerAnnotLine */
> > +void
> > +poppler_annot_line_set_width (PopplerAnnotLine *poppler_annot, gdouble width)
>
> This should be documented. Use a new line for every parameter-
>
> @@ +1447,5 @@
> > + g_return_if_fail (POPPLER_IS_ANNOT_LINE (poppler_annot));
> > +
> > + annot = static_cast<AnnotLine *>(POPPLER_ANNOT (poppler_annot)->annot);
> > + annot->setLeaderLineLength(width);
> > + annot->setLeaderLineExtension(width);
>
> This is confusing, because this only applies to annot lines using leader
> lines. Note that simply calling this, changes the meaning of the vertices.
> In a normal lines the width is determined but its vertices, since it's a
> rectangle in the end. I'm not sure how to expose the leader lines thing,
> though.</span >
None of them seems to work. I had forgotten to split the patch because I was
testing some things with this.
<span class="quote">> @@ +1454,5 @@
> > +
> > +void
> > +poppler_annot_line_set_vertices (PopplerAnnotLine *poppler_annot,
> > + gdouble x1, gdouble y1,
> > + gdouble x2, gdouble y2)
>
> I wonder if we should to expose PopplerPoint, I guess it will be required if
> we eventually expose Polygon annotations.</span >
It is kind of redundant to initialize both, PopplerRect and PopplerPoint with
similar values. However, PopplerPoint seems to make the API simpler to
understand.
I removed everything else that is only noise for very simple lines, and they
were not working. In Poppler there are some "TODO" marked in the
implementation
of lines, so better to leave it for later.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>