<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add getter and setter for annotation's rectangle"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70901#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add getter and setter for annotation's rectangle"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70901">bug 70901</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=89305" name="attach_89305" title="glib: Add getter and setter for annotation's rectangle">attachment 89305</a> <a href="attachment.cgi?id=89305&action=edit" title="glib: Add getter and setter for annotation's rectangle">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=70901&attachment=89305'>[review]</a>
glib: Add getter and setter for annotation's rectangle
Review of <span class=""><a href="attachment.cgi?id=89305" name="attach_89305" title="glib: Add getter and setter for annotation's rectangle">attachment 89305</a> <a href="attachment.cgi?id=89305&action=edit" title="glib: Add getter and setter for annotation's rectangle">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=70901&attachment=89305'>[review]</a>:
-----------------------------------------------------------------
I've pushed it to git master with some modifications. Thanks.
::: glib/poppler-annot.cc
@@ +686,5 @@
<span class="quote">> + *
> + * Retrieves the rectangle representing the page coordinates where the
> + * annotation @poppler_annot is placed.
> + *
> + * If @poppler_annot is an invalid annotation, then @poppler_rect is not set.</span >
I've removed this, because passing an invalid annot is not something expected,
and the sentence is not true if g_return macros are disabled, in that case it
will crash.
@@ +696,5 @@
<span class="quote">> + PopplerRectangle *poppler_rect)
> +{
> + PDFRectangle *annot_rect;
> +
> + g_return_if_fail (POPPLER_IS_ANNOT (poppler_annot));</span >
We should also check here that poppler_rect passed is not NULL.
@@ +717,5 @@
<span class="quote">> + * Since: 0.26
> + */
> +void
> +poppler_annot_set_rectangle (PopplerAnnot *poppler_annot,
> + PopplerRectangle poppler_rect)</span >
I still think this should receive a pointer, so I've changed this too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>