<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - glib-demo: Add support for simple line annotations" href="https://bugs.freedesktop.org/show_bug.cgi?id=70981#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - glib-demo: Add support for simple line annotations" href="https://bugs.freedesktop.org/show_bug.cgi?id=70981">bug 70981</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>Comment on <a href="attachment.cgi?id=89307" name="attach_89307" title="glib: Add PopplerPoint boxed type">attachment 89307</a> <a href="attachment.cgi?id=89307&action=edit" title="glib: Add PopplerPoint boxed type">[details]</a> <a href='page.cgi?id=splinter.html&bug=70981&attachment=89307'>[review]</a> glib: Add PopplerPoint boxed type Review of <a href="attachment.cgi?id=89307" name="attach_89307" title="glib: Add PopplerPoint boxed type">attachment 89307</a> <a href="attachment.cgi?id=89307&action=edit" title="glib: Add PopplerPoint boxed type">[details]</a> <a href='page.cgi?id=splinter.html&bug=70981&attachment=89307'>[review]</a>: ----------------------------------------------------------------- Looks good, but I don't think we should assume a point represents only the position of an annotation in the page, I think it's generic even if it's only used by the annotations API at the moment. So, I would move it to poppler-page, like PopplerRectangle or PopplerColor. ::: glib/poppler-annot.h @@ +178,5 @@ > + * @x: x coordinate > + * @y: y coordinate > + * > + * A #PopplerPoint is used to describe a location point for an annotation > + * on a page s/for an annotation//</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>