<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - glib-demo: Add support for simple line annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70981#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - glib-demo: Add support for simple line annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70981">bug 70981</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=89308" name="attach_89308" title="glib: Add support for simple line annotations">attachment 89308</a> <a href="attachment.cgi?id=89308&action=edit" title="glib: Add support for simple line annotations">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=70981&attachment=89308'>[review]</a>
glib: Add support for simple line annotations
Review of <span class=""><a href="attachment.cgi?id=89308" name="attach_89308" title="glib: Add support for simple line annotations">attachment 89308</a> <a href="attachment.cgi?id=89308&action=edit" title="glib: Add support for simple line annotations">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=70981&attachment=89308'>[review]</a>:
-----------------------------------------------------------------
Looks great, I have just a few minor comments
::: glib/poppler-annot.cc
@@ +1495,5 @@
<span class="quote">> +/* PopplerAnnotLine */
> +/**
> + * poppler_annot_line_set_vertices:
> + * @poppler_annot: a #PopplerAnnotLine
> + * @start: Coordinates of the starting vertice</span >
a #PopplerPoint ... so that we have a link ot the PopplerPoint documentation
here
@@ +1496,5 @@
<span class="quote">> +/**
> + * poppler_annot_line_set_vertices:
> + * @poppler_annot: a #PopplerAnnotLine
> + * @start: Coordinates of the starting vertice
> + * @end: Coordinates of the starting vertice</span >
Ditto.
@@ +1498,5 @@
<span class="quote">> + * @poppler_annot: a #PopplerAnnotLine
> + * @start: Coordinates of the starting vertice
> + * @end: Coordinates of the starting vertice
> + *
> + * Set the point the coordinates where the @poppler_annot starts and ends.</span >
the point the coordinates?
@@ +1505,5 @@
<span class="quote">> + */
> +void
> +poppler_annot_line_set_vertices (PopplerAnnotLine *poppler_annot,
> + PopplerPoint start,
> + PopplerPoint end)</span >
Use pointers for start and end
@@ +1509,5 @@
<span class="quote">> + PopplerPoint end)
> +{
> + AnnotLine *annot;
> +
> + g_return_if_fail (POPPLER_IS_ANNOT_LINE (poppler_annot));</span >
check also here that start and end are both != NULL</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>