<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Make demo extensible for other type of annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=69978#c29">Comment # 29</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Make demo extensible for other type of annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=69978">bug 69978</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=88199" name="attach_88199" title="glib-demo: Add annotations interactively">attachment 88199</a> <a href="attachment.cgi?id=88199&action=edit" title="glib-demo: Add annotations interactively">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=69978&attachment=88199'>[review]</a>
glib-demo: Add annotations interactively
Review of <span class=""><a href="attachment.cgi?id=88199" name="attach_88199" title="glib-demo: Add annotations interactively">attachment 88199</a> <a href="attachment.cgi?id=88199&action=edit" title="glib-demo: Add annotations interactively">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=69978&attachment=88199'>[review]</a>:
-----------------------------------------------------------------
::: glib/demo/annots.c
@@ +825,5 @@
<span class="quote">> + rect.x2 = demo->stop.x;
> + rect.y2 = height - demo->stop.y;
> + switch (demo->annot_type) {
> + case POPPLER_ANNOT_TEXT:
> + annot = poppler_annot_text_new (demo->doc, &rect);</span >
The annotation is leaked here. When it's added to the model, the model takes a
reference, and this one is never released, so we should call g_object_unref
after add_annot_to_model</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>