<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add implementation of Square and Circle annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70983#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add implementation of Square and Circle annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70983">bug 70983</a>
from <span class="vcard"><a class="email" href="mailto:gpoo@gnome.org" title="Germán Poo-Caamaño <gpoo@gnome.org>"> <span class="fn">Germán Poo-Caamaño</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=70983#c2">comment #2</a>)
<span class="quote">> @@ +433,5 @@
> > + border = new AnnotBorderArray ();
> > + border->setWidth (1.5);
> > +
> > + annot = new AnnotGeometry (doc->doc, &pdf_rect, Annot::typeCircle);
> > + annot->setBorder (border);
>
> Why do we set a border by default? The BS entry is optional.</span >
If we don't set the border, we get an "invisible" square/circle.
One way to enable it is good a sensible default. The alternatives
are:
- A hard coded sensible default
- Receive *line_width, if NULL then not set anything. Otherwise,
set the width.
- Add in the documentation that to create a visible circle/square it is
required to call an additional method (set_border_width) afterwards.
- Not do anything at all
I am going to submit an updated patch with last one.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>