<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - glib-demo: Add support for simple line annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70981#c18">Comment # 18</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - glib-demo: Add support for simple line annotations"
href="https://bugs.freedesktop.org/show_bug.cgi?id=70981">bug 70981</a>
from <span class="vcard"><a class="email" href="mailto:gpoo@gnome.org" title="Germán Poo-Caamaño <gpoo@gnome.org>"> <span class="fn">Germán Poo-Caamaño</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=70981#c17">comment #17</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=70981#c13">comment #13</a>)
> > (In reply to <a href="show_bug.cgi?id=70981#c9">comment #9</a>)
> > > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=89308" name="attach_89308" title="glib: Add support for simple line annotations">attachment 89308</a> <a href="attachment.cgi?id=89308&action=edit" title="glib: Add support for simple line annotations">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=70981&attachment=89308'>[review]</a> [review] [review] [review]
> > > [...]
> > > @@ +1505,5 @@
> > > > + */
> > > > +void
> > > > +poppler_annot_line_set_vertices (PopplerAnnotLine *poppler_annot,
> > > > + PopplerPoint start,
> > > > + PopplerPoint end)
> > >
> > > Use pointers for start and end
> >
> > why do you prefer pointers on this one?
>
> To avoid copying the struct like in the poppler_annot_set_rectangle case.</span >
Ok, thanks. FWIW, the patch addresses this and the other comments.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>