<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] Add support for TextMarkup Annotations in glib frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=51487#c28">Comment # 28</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - [PATCH] Add support for TextMarkup Annotations in glib frontend" href="https://bugs.freedesktop.org/show_bug.cgi?id=51487">bug 51487</a> from <a class="email" href="mailto:gpoo@gnome.org" title="Germán Poo-Caamaño <gpoo@gnome.org>"> Germán Poo-Caamaño</a> <pre>(In reply to <a href="show_bug.cgi?id=51487#c25">comment #25</a>) > Comment on <a href="attachment.cgi?id=88272" name="attach_88272" title="glib-demo: Add support for PopplerTextAnnotMarkup">attachment 88272</a> <a href="attachment.cgi?id=88272&action=edit" title="glib-demo: Add support for PopplerTextAnnotMarkup">[details]</a> <a href='page.cgi?id=splinter.html&bug=51487&attachment=88272'>[review]</a> [review] > glib-demo: Add support for PopplerTextAnnotMarkup > > Review of <a href="attachment.cgi?id=88272" name="attach_88272" title="glib-demo: Add support for PopplerTextAnnotMarkup">attachment 88272</a> <a href="attachment.cgi?id=88272&action=edit" title="glib-demo: Add support for PopplerTextAnnotMarkup">[details]</a> <a href='page.cgi?id=splinter.html&bug=51487&attachment=88272'>[review]</a> [review]: > ----------------------------------------------------------------- > [...] > @@ +217,5 @@ > > + * > > + * Since: 0.25 > > + **/ > > +PopplerAnnotQuadrilateral * > > +poppler_annot_quadrilateral_new (void) > > I think the constructor should receive the points. Shouldn't that be inconsistent with other similar boxed types such as PopplerPoint, PopplerRectangle, PopplerColor?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>