<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Add support for TextMarkup Annotations in glib frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=51487#c30">Comment # 30</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [PATCH] Add support for TextMarkup Annotations in glib frontend"
href="https://bugs.freedesktop.org/show_bug.cgi?id=51487">bug 51487</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=51487#c28">comment #28</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=51487#c25">comment #25</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=88272" name="attach_88272" title="glib-demo: Add support for PopplerTextAnnotMarkup">attachment 88272</a> <a href="attachment.cgi?id=88272&action=edit" title="glib-demo: Add support for PopplerTextAnnotMarkup">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=51487&attachment=88272'>[review]</a> [review] [review]
> > glib-demo: Add support for PopplerTextAnnotMarkup
> >
> > Review of <span class="bz_obsolete"><a href="attachment.cgi?id=88272" name="attach_88272" title="glib-demo: Add support for PopplerTextAnnotMarkup">attachment 88272</a> <a href="attachment.cgi?id=88272&action=edit" title="glib-demo: Add support for PopplerTextAnnotMarkup">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=51487&attachment=88272'>[review]</a> [review] [review]:
> > -----------------------------------------------------------------
> > [...]
> > @@ +217,5 @@
> > > + *
> > > + * Since: 0.25
> > > + **/
> > > +PopplerAnnotQuadrilateral *
> > > +poppler_annot_quadrilateral_new (void)
> >
> > I think the constructor should receive the points.
>
> Shouldn't that be inconsistent with other similar boxed types such as
> PopplerPoint, PopplerRectangle, PopplerColor?</span >
Good point.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>