<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64815#c65">Comment # 65</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Parse the Tagged-PDF document structure tree when present"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64815">bug 64815</a>
from <span class="vcard"><a class="email" href="mailto:aperez@igalia.com" title="Adrian Perez de Castro <aperez@igalia.com>"> <span class="fn">Adrian Perez de Castro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=64815#c64">comment #64</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=90249" name="attach_90249" title="[PATCH v12 01/11] Tagged-PDF: Text content extraction from structure elements">attachment 90249</a> <a href="attachment.cgi?id=90249&action=edit" title="[PATCH v12 01/11] Tagged-PDF: Text content extraction from structure elements">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64815&attachment=90249'>[review]</a> [review]
> [PATCH v12 01/11] Tagged-PDF: Text content extraction from structure elements
>
> Review of <span class=""><a href="attachment.cgi?id=90249" name="attach_90249" title="[PATCH v12 01/11] Tagged-PDF: Text content extraction from structure elements">attachment 90249</a> <a href="attachment.cgi?id=90249&action=edit" title="[PATCH v12 01/11] Tagged-PDF: Text content extraction from structure elements">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64815&attachment=90249'>[review]</a> [review]:
> -----------------------------------------------------------------
>
> ::: poppler/MarkedContentOutputDev.cc
> @@ +135,5 @@
> > + // the render mode (for mode 1 stroke color is used), so there is no need
> > + // to implement both updateFillColor() and updateStrokeColor().
> > + GBool colorChange = gFalse;
> > + GfxRGB color;
> > + if (state->getRender() == 1)
>
> This is a mask, it should be if ((state->getRender() & 3) == 1)</span >
Done. Also, the updated version I am uploading has better code for GfxFont
comparison.
(See <a href="http://lists.freedesktop.org/archives/poppler/2013-December/010702.html">http://lists.freedesktop.org/archives/poppler/2013-December/010702.html</a>)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>