<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cannot compile poppler with Qt5 frontend on Win 8 with Visual Studio 2012" href="https://bugs.freedesktop.org/show_bug.cgi?id=73111#c3">Comment # 3</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Cannot compile poppler with Qt5 frontend on Win 8 with Visual Studio 2012" href="https://bugs.freedesktop.org/show_bug.cgi?id=73111">bug 73111</a> from <a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> Adrian Johnson</a> <pre>(In reply to <a href="show_bug.cgi?id=73111#c2">comment #2</a>) > Created <a href="attachment.cgi?id=91276" name="attach_91276" title="patch for poppler compilation with Qt5 frontend on Win8 with VS 2012">attachment 91276</a> <a href="attachment.cgi?id=91276&action=edit" title="patch for poppler compilation with Qt5 frontend on Win8 with VS 2012">[details]</a> <a href='page.cgi?id=splinter.html&bug=73111&attachment=91276'>[review]</a> [review] > patch for poppler compilation with Qt5 frontend on Win8 with VS 2012 The #define NOMINAX should go in each header file that include windows.h. Otherwise we will have the same problem the next time someone adds a max or min to another file. > Here is the patch with the suggested correction. I would also recommend to > replace all _WIN32 with _MSC_VER which is more generic than looking for > _WIN32 only _WIN32 is defined when compiling for the windows platform. _MSC_VER is defined when compiling with VC++. If compiling with MinGW (either natively or cross compiling) _WIN32 will be defined but not _MSC_VER. Looking at your patch the you should be using _WIN32 as it is all windows platform specific stuff (generally anything related to windows.h). _MSC_VER is only used to handle the differences between VC++ and GCC.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>