<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - install error callback to redirect errors to the GLib logging framework"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73269#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - install error callback to redirect errors to the GLib logging framework"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73269">bug 73269</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=92386" name="attach_92386" title="make the strings a bit more informative">attachment 92386</a> <a href="attachment.cgi?id=92386&action=edit" title="make the strings a bit more informative">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=73269&attachment=92386'>[review]</a>
make the strings a bit more informative
Review of <span class=""><a href="attachment.cgi?id=92386" name="attach_92386" title="make the strings a bit more informative">attachment 92386</a> <a href="attachment.cgi?id=92386&action=edit" title="make the strings a bit more informative">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=73269&attachment=92386'>[review]</a>:
-----------------------------------------------------------------
Yes, a lot simpler, and we don't need new API nor even change evince.
::: glib/poppler.cc
@@ +90,5 @@
<span class="quote">> + category == errCommandLine ||
> + category == errNotAllowed)
> + return;
> +
> + g_log (G_LOG_DOMAIN, G_LOG_LEVEL_INFO,</span >
Shouldn't we use "Poppler" as log domain?
@@ +95,5 @@
<span class="quote">> + "%s at position %" G_GOFFSET_FORMAT ": %s",
> + cat_str[category], (goffset) pos, message);
> +}
> +
> +static void poppler_constructor (void) __attribute__((__constructor__));</span >
Why do you need this prototype? I think you can annotate the method directly,
for example:
static void __attribute__((__constructor__)) poppler_constructor (void)
{
setErrorCallback (error_cb, NULL);
}</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>