<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:chpe@gnome.org" title="Christian Persch (GNOME) <chpe@gnome.org>"> <span class="fn">Christian Persch (GNOME)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW --- - install error callback to redirect errors to the GLib logging framework"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73269">bug 73269</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #92386 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - install error callback to redirect errors to the GLib logging framework"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73269#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - install error callback to redirect errors to the GLib logging framework"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73269">bug 73269</a>
from <span class="vcard"><a class="email" href="mailto:chpe@gnome.org" title="Christian Persch (GNOME) <chpe@gnome.org>"> <span class="fn">Christian Persch (GNOME)</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=92409" name="attach_92409" title="updated patch">attachment 92409</a> <a href="attachment.cgi?id=92409&action=edit" title="updated patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=73269&attachment=92409'>[review]</a>
updated patch
(In reply to <a href="show_bug.cgi?id=73269#c6">comment #6</a>)
<span class="quote">> > + g_log (G_LOG_DOMAIN, G_LOG_LEVEL_INFO,
>
> Shouldn't we use "Poppler" as log domain?</span >
It does; G_LOG_DOMAIN is #define'd to "Poppler" in Makefile.am (INCLUDES).
<span class="quote">> > +static void poppler_constructor (void) __attribute__((__constructor__));
>
> Why do you need this prototype? I think you can annotate the method
> directly, for example:
>
> static void __attribute__((__constructor__)) poppler_constructor (void)
> {
> setErrorCallback (error_cb, NULL);
> }</span >
Fixed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>