<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - install error callback to redirect errors to the GLib logging framework"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=73269">bug 73269</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Status</td>
           <td>NEW
           </td>
           <td>RESOLVED
           </td>
         </tr>

         <tr>
           <td style="text-align:right;">Resolution</td>
           <td>---
           </td>
           <td>FIXED
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - install error callback to redirect errors to the GLib logging framework"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=73269#c8">Comment # 8</a>
              on <a class="bz_bug_link 
          bz_status_RESOLVED  bz_closed"
   title="RESOLVED FIXED - install error callback to redirect errors to the GLib logging framework"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=73269">bug 73269</a>
              from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
        <pre>(In reply to <a href="show_bug.cgi?id=73269#c7">comment #7</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=92409" name="attach_92409" title="updated patch">attachment 92409</a> <a href="attachment.cgi?id=92409&action=edit" title="updated patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=73269&attachment=92409'>[review]</a> [review]
> updated patch

> (In reply to <a href="show_bug.cgi?id=73269#c6">comment #6</a>)
> > > +  g_log (G_LOG_DOMAIN, G_LOG_LEVEL_INFO,
> > 
> > Shouldn't we use "Poppler" as log domain?

> It does; G_LOG_DOMAIN is #define'd to "Poppler" in Makefile.am (INCLUDES).</span >

Oh, right!

<span class="quote">> > > +static void poppler_constructor (void) __attribute__((__constructor__));
> > 
> > Why do you need this prototype? I think you can annotate the method
> > directly, for example:
> > 
> > static void __attribute__((__constructor__)) poppler_constructor (void)
> > {
> >   setErrorCallback (error_cb, NULL);
> > }

> Fixed.</span >

Pushed to git master, thank you very much.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>