<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821#c53">Comment # 53</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821">bug 64821</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=90268" name="attach_90268" title="[PATCH v12 11/11] glib-demo: Pane showing the document structure">attachment 90268</a> <a href="attachment.cgi?id=90268&action=edit" title="[PATCH v12 11/11] glib-demo: Pane showing the document structure">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=90268'>[review]</a>
[PATCH v12 11/11] glib-demo: Pane showing the document structure
Review of <span class=""><a href="attachment.cgi?id=90268" name="attach_90268" title="[PATCH v12 11/11] glib-demo: Pane showing the document structure">attachment 90268</a> <a href="attachment.cgi?id=90268&action=edit" title="[PATCH v12 11/11] glib-demo: Pane showing the document structure">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=90268'>[review]</a>:
-----------------------------------------------------------------
::: glib/demo/main.c
@@ +66,4 @@
<span class="quote">> { "Attachments", pgd_attachments_create_widget },
> { "Layers", pgd_layers_create_widget },
> { "Text", pgd_text_create_widget },
> + { "Tagged Structure", pgd_taggedstruct_create_widget },</span >
Bad indented.
::: glib/demo/taggedstruct.c
@@ +52,5 @@
<span class="quote">> +
> +static void
> +populate_store_aux (GtkTreeStore *store, GtkTreeIter *parent, PopplerStructureElementIter *iter)
> +{
> + g_print ("iter %p\n", iter);</span >
Remove this.
@@ +95,5 @@
<span class="quote">> +}
> +
> +
> +static void
> +pgd_row_activated (GtkTreeView *tree_view, GtkTreePath *path, GtkTreeViewColumn *column, gpointer user_data)</span >
You can use PgdTaggedStructDemo *demo directly instead of user_data since you
are using a cast for the callback in g_signal_connect
@@ +138,5 @@
<span class="quote">> + }
> +
> + gtk_label_set_text (GTK_LABEL (demo->link_target), "");
> + if (poppler_structure_element_get_reference_type (element) ==
> + POPPLER_STRUCTURE_REFERENCE_LINK)</span >
I haven't found the patch that adds the reference link.
@@ +250,5 @@
<span class="quote">> + G_CALLBACK (pgd_row_activated),
> + demo);
> + g_signal_connect (demo->view, "cursor-changed",
> + G_CALLBACK (pgd_cursor_changed),
> + demo);</span >
I think GtkTreeSelection::changed is what you want instead of these two
signals.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>