<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821#c55">Comment # 55</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Expose the structure tree and attributes in poppler-glib"
href="https://bugs.freedesktop.org/show_bug.cgi?id=64821">bug 64821</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=90266" name="attach_90266" title="[PATCH v12 09/11] glib: Accessors for document structure references">attachment 90266</a> <a href="attachment.cgi?id=90266&action=edit" title="[PATCH v12 09/11] glib: Accessors for document structure references">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=90266'>[review]</a>
[PATCH v12 09/11] glib: Accessors for document structure references
Review of <span class=""><a href="attachment.cgi?id=90266" name="attach_90266" title="[PATCH v12 09/11] glib: Accessors for document structure references">attachment 90266</a> <a href="attachment.cgi?id=90266&action=edit" title="[PATCH v12 09/11] glib: Accessors for document structure references">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=64821&attachment=90266'>[review]</a>:
-----------------------------------------------------------------
::: glib/poppler-structure-element.cc
@@ +819,5 @@
<span class="quote">>
> /**
> + * poppler_structure_element_get_form_field:
> + * @poppler_structure_element: A #PopplerStructureElement
> + *</span >
You should explain briefly here what this method is for.
@@ +822,5 @@
<span class="quote">> + * @poppler_structure_element: A #PopplerStructureElement
> + *
> + * Return value: (transfer full): A #PopplerFormField, or %NULL if
> + * the element is not a %POPPLER_STRUCTURE_ELEMENT_FORM.
> + */</span >
Since: 0.26
@@ +827,5 @@
<span class="quote">> +PopplerFormField *
> +poppler_structure_element_get_form_field (PopplerStructureElement *poppler_structure_element)
> +{
> + g_return_val_if_fail (POPPLER_IS_STRUCTURE_ELEMENT (poppler_structure_element), NULL);
> + g_assert (poppler_structure_element->elem);</span >
Use g_return macros in public elements.
@@ +861,5 @@
<span class="quote">> + field_id);
> +}
> +
> +/**
> + * poppler_structure_element_get_form_field_mapping:</span >
I still think this method is a bit weird. I think it should be the page the one
returning a mapping.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>