<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Accomodate for future extension of poppler_structure_element_get_text()"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75796#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - [TAGGEDPDF] Accomodate for future extension of poppler_structure_element_get_text()"
href="https://bugs.freedesktop.org/show_bug.cgi?id=75796">bug 75796</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=95165" name="attach_95165" title="[PATCH] glib: Use flags argument in poppler_structure_element_get_text()">attachment 95165</a> <a href="attachment.cgi?id=95165&action=edit" title="[PATCH] glib: Use flags argument in poppler_structure_element_get_text()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=75796&attachment=95165'>[review]</a>
[PATCH] glib: Use flags argument in poppler_structure_element_get_text()
Review of <span class=""><a href="attachment.cgi?id=95165" name="attach_95165" title="[PATCH] glib: Use flags argument in poppler_structure_element_get_text()">attachment 95165</a> <a href="attachment.cgi?id=95165&action=edit" title="[PATCH] glib: Use flags argument in poppler_structure_element_get_text()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=75796&attachment=95165'>[review]</a>:
-----------------------------------------------------------------
::: glib/poppler-structure-element.cc
@@ +666,4 @@
<span class="quote">> /**
> * poppler_structure_element_get_text:
> * @poppler_structure_element: A #PopplerStructureElement
> + * @flags: A #PopplerStructureGetTextFlags value, or %0 to disable</span >
Yes, this is much better than a boolean parameter, but please, use a value in
the enum instead of this 0 here. Something like POPPLER_STRUCTURE_GET_TEXT_NONE</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>