<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - SEGV in RescaleDrawImage::getRow"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76445#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - SEGV in RescaleDrawImage::getRow"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76445">bug 76445</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=96518" name="attach_96518" title="fix segv">attachment 96518</a> <a href="attachment.cgi?id=96518&action=edit" title="fix segv">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=76445&attachment=96518'>[review]</a>
fix segv
Review of <span class=""><a href="attachment.cgi?id=96518" name="attach_96518" title="fix segv">attachment 96518</a> <a href="attachment.cgi?id=96518&action=edit" title="fix segv">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=76445&attachment=96518'>[review]</a>:
-----------------------------------------------------------------
Thanks Adrian, I have a couple of questions
::: poppler/CairoOutputDev.cc
@@ +2839,4 @@
<span class="quote">> current_row++;
> }
>
> + if (unlikely(pix == NULL)) {</span >
So, if I understand correctly, the problem is that for buggy PDF documents,
ImageStream::getLine can return NULL, right? What about the other places where
we use it too? Could we make getRow() return bool and abort the image decode
when it returns false?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>