<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - SEGV in RescaleDrawImage::getRow"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76445#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - SEGV in RescaleDrawImage::getRow"
href="https://bugs.freedesktop.org/show_bug.cgi?id=76445">bug 76445</a>
from <span class="vcard"><a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> <span class="fn">Adrian Johnson</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=76445#c5">comment #5</a>)
<span class="quote">> So, if I understand correctly, the problem is that for buggy PDF documents,
> ImageStream::getLine can return NULL, right?</span >
Correct.
<span class="quote">> What about the other places
> where we use it too?</span >
I would wait for a PDF that reproduces the problem before I fix it.
<span class="quote">> Could we make getRow() return bool and abort the image
> decode when it returns false?</span >
We want to continue on with rendering as much of the document as possible. It
is easier to return zero data when the image stream fails than to add checks
all the way up the stack trace to the drawImage function to handle an error
status.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>