<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Compilation of Qt5 frontend fails with MinGW" href="https://bugs.freedesktop.org/show_bug.cgi?id=79874#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Compilation of Qt5 frontend fails with MinGW" href="https://bugs.freedesktop.org/show_bug.cgi?id=79874">bug 79874</a> from <a class="email" href="mailto:freedesktop@akikoskinen.info" title="Aki Koskinen <freedesktop@akikoskinen.info>"> Aki Koskinen</a> <pre>(In reply to <a href="show_bug.cgi?id=79874#c1">comment #1</a>) > hmmmm, i'm unconvinced by the patch, can poppler compiled that way still > open files with non-ascii characters? I'm not sure. It's completely OK to discard the proposed patch. Another way (possibly better) would be to replace the non-standard _Copy_s with something standard, like copy. The additional bounds checking provided by _Copy_s doesn't seem to bring any benefit since we already know that fileName is large enough (since we just constructed it). Or then not copy at all - I don't quite get why the copying is needed in the first place. Would something like this do the job (note: untested code): doc = new PDFDoc((const wchar_t *)filePath.utf16(), filePath.length(), ownerPassword, userPassword);</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>