<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - poppler_structure_element_get_table_{row,column}_span() apply to cell elements; not table elements" href="https://bugs.freedesktop.org/show_bug.cgi?id=80308#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - poppler_structure_element_get_table_{row,column}_span() apply to cell elements; not table elements" href="https://bugs.freedesktop.org/show_bug.cgi?id=80308">bug 80308</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>(In reply to <a href="show_bug.cgi?id=80308#c0">comment #0</a>) > Created <a href="attachment.cgi?id=101452" name="attach_101452" title="proposed patch">attachment 101452</a> <a href="attachment.cgi?id=101452&action=edit" title="proposed patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=80308&attachment=101452'>[review]</a> [review] > proposed patch > > As per the PDF spec, cell elements (TD and TH) have row and column spans. > But poppler_structure_element_get_table_row_span() and > poppler_structure_element_get_table_column_span() each expect a table > element -- which of course has no span attributes defined and thus the > default value of 1 (as per the spec) is always returned by these methods. > (Unless of course you ask for the spans of a cell in which case you get an > error.) hmm, it seems other table elements have the same problem: - poppler_structure_element_get_table_headers: This attribute may apply to header cells (TH) as well as data cells (TD) - poppler_structure_element_get_table_scope: This attribute shall only be used when the structure type of the element is TH Could you please fix those too?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>