<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Extend support for free text annotations."
href="https://bugs.freedesktop.org/show_bug.cgi?id=81665#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Extend support for free text annotations."
href="https://bugs.freedesktop.org/show_bug.cgi?id=81665">bug 81665</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=103328" name="attach_103328" title="4/4. Core: Fix issue when adding annot without contents">attachment 103328</a> <a href="attachment.cgi?id=103328&action=edit" title="4/4. Core: Fix issue when adding annot without contents">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=81665&attachment=103328'>[review]</a>
4/4. Core: Fix issue when adding annot without contents
Review of <span class=""><a href="attachment.cgi?id=103328" name="attach_103328" title="4/4. Core: Fix issue when adding annot without contents">attachment 103328</a> <a href="attachment.cgi?id=103328&action=edit" title="4/4. Core: Fix issue when adding annot without contents">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=81665&attachment=103328'>[review]</a>:
-----------------------------------------------------------------
::: poppler/Annot.cc
@@ +3015,5 @@
<span class="quote">> fontsize = 10;
> if (fontcolor == NULL)
> fontcolor = new AnnotColor(0, 0, 0); // Black
> + if (!contents)
> + contents = new GooString ("");</span >
hmm, the thing is a bit inconsistent with regards to contents. In
Annot::initialize we set it to NULL when the entry is not present in the dict,
but in Annot::setContents() we create an empty GooString when the new contents
are NULL. I think we should either set it to NULL in Annot::setContents() or
create an empty string in Annot::initialize. If we decide to use NULL for no
contents, it would be better to check it here and not add any text operator to
the appearance stream when it's NULL.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>