<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Extend support for free text annotations." href="https://bugs.freedesktop.org/show_bug.cgi?id=81665#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Extend support for free text annotations." href="https://bugs.freedesktop.org/show_bug.cgi?id=81665">bug 81665</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>Comment on <a href="attachment.cgi?id=103325" name="attach_103325" title="1/4. glib: Add PopplerAnnotAppearance boxed type">attachment 103325</a> <a href="attachment.cgi?id=103325&action=edit" title="1/4. glib: Add PopplerAnnotAppearance boxed type">[details]</a> <a href='page.cgi?id=splinter.html&bug=81665&attachment=103325'>[review]</a> 1/4. glib: Add PopplerAnnotAppearance boxed type Review of <a href="attachment.cgi?id=103325" name="attach_103325" title="1/4. glib: Add PopplerAnnotAppearance boxed type">attachment 103325</a> <a href="attachment.cgi?id=103325&action=edit" title="1/4. glib: Add PopplerAnnotAppearance boxed type">[details]</a> <a href='page.cgi?id=splinter.html&bug=81665&attachment=103325'>[review]</a>: ----------------------------------------------------------------- I'm not sure about exposing annotation appearances as a boxed type in the public API. It's a bit confusing because all annotations have an appearance, that is more than just font name, size and color. This is to support the default appearance (DA) of free text annotations, so maybe we can add specific API for free text annotations. The main problem is that the default appearance is a required parameter when creating the annot, so if we add parameters to the constructor we won't be able to extend them in the future if needed without breaking the API.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>