<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - Extend support for free text annotations." href="https://bugs.freedesktop.org/show_bug.cgi?id=81665#c12">Comment # 12</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - Extend support for free text annotations." href="https://bugs.freedesktop.org/show_bug.cgi?id=81665">bug 81665</a> from <a class="email" href="mailto:jose.aliste@gmail.com" title="Jose Aliste <jose.aliste@gmail.com>"> Jose Aliste</a> <pre>Comment on <a href="attachment.cgi?id=103426" name="attach_103426" title="[PATCH 1/4] glib: Extend FreeText annotation support">attachment 103426</a> <a href="attachment.cgi?id=103426&action=edit" title="[PATCH 1/4] glib: Extend FreeText annotation support">[details]</a> <a href='page.cgi?id=splinter.html&bug=81665&attachment=103426'>[review]</a> [PATCH 1/4] glib: Extend FreeText annotation support Review of <a href="attachment.cgi?id=103426" name="attach_103426" title="[PATCH 1/4] glib: Extend FreeText annotation support">attachment 103426</a> <a href="attachment.cgi?id=103426&action=edit" title="[PATCH 1/4] glib: Extend FreeText annotation support">[details]</a> <a href='page.cgi?id=splinter.html&bug=81665&attachment=103426'>[review]</a>: ----------------------------------------------------------------- This looks much better. Although, see the comment bellow ::: glib/poppler-annot.cc @@ +1896,5 @@ > + annot = static_cast<AnnotFreeText *>(POPPLER_ANNOT (poppler_annot)->annot); > + annot->setAppearanceString (da); > + delete da; > +} > + We already know that we want the font type to be changed accessed, so the API should have some PangoFontDescription or so to get and set the font + the color. Even if Poppler Core does not support different fonts in FreeText Annot, I believe we want the API to be right in glib right away.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>