<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add support for printing to a Windows printer from pdftocairo"
href="https://bugs.freedesktop.org/show_bug.cgi?id=79936#c33">Comment # 33</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Add support for printing to a Windows printer from pdftocairo"
href="https://bugs.freedesktop.org/show_bug.cgi?id=79936">bug 79936</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=106267" name="attach_106267" title="Allow an output file for win32 printing to be specified">attachment 106267</a> <a href="attachment.cgi?id=106267&action=edit" title="Allow an output file for win32 printing to be specified">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=79936&attachment=106267'>[review]</a>
Allow an output file for win32 printing to be specified
Review of <span class=""><a href="attachment.cgi?id=106267" name="attach_106267" title="Allow an output file for win32 printing to be specified">attachment 106267</a> <a href="attachment.cgi?id=106267&action=edit" title="Allow an output file for win32 printing to be specified">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=79936&attachment=106267'>[review]</a>:
-----------------------------------------------------------------
why GSView? :-P Patch LGTM
::: utils/pdftocairo-win32.cc
@@ +188,5 @@
<span class="quote">> + docinfo.lpszDocName = inputFileName->getCString();
> + }
> + if (outputFileName) {
> + docinfo.lpszOutput = outputFileName->getCString();
> + }</span >
Why have you added braces everywhere?
::: utils/pdftocairo.cc
@@ +741,5 @@
<span class="quote">> }
>
> + if (print) {
> + return NULL; // No output file means print to printer
> + }</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>