<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - pdftocairo -svg renders a jpeg image with inverted color" href="https://bugs.freedesktop.org/show_bug.cgi?id=80719#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_REOPENED " title="REOPENED - pdftocairo -svg renders a jpeg image with inverted color" href="https://bugs.freedesktop.org/show_bug.cgi?id=80719">bug 80719</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>Comment on <a href="attachment.cgi?id=107384" name="attach_107384" title="only embed mime data if decode map is identity">attachment 107384</a> <a href="attachment.cgi?id=107384&action=edit" title="only embed mime data if decode map is identity">[details]</a> <a href='page.cgi?id=splinter.html&bug=80719&attachment=107384'>[review]</a> only embed mime data if decode map is identity Review of <a href="attachment.cgi?id=107384" name="attach_107384" title="only embed mime data if decode map is identity">attachment 107384</a> <a href="attachment.cgi?id=107384&action=edit" title="only embed mime data if decode map is identity">[details]</a> <a href='page.cgi?id=splinter.html&bug=80719&attachment=107384'>[review]</a>: ----------------------------------------------------------------- ::: poppler/CairoOutputDev.cc @@ +2719,5 @@ > + // only embed mime data if image decode map is identiy > + for (i = 0; i < colorMap->getNumPixelComps(); i++) { > + if (colorMap->getDecodeLow(i) != 0.0 || colorMap->getDecodeHigh(i) != 1.0) > + return; > + } Looks good, maybe we could add a helper method for this, and we don't need the comment to explain it. something like: if (!colorMapHasIdentityDecodeMap(colorMap)) return; Or something similar.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>