<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [pdfdetach] Segfault in Page.cc:400"
href="https://bugs.freedesktop.org/show_bug.cgi?id=85145#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [pdfdetach] Segfault in Page.cc:400"
href="https://bugs.freedesktop.org/show_bug.cgi?id=85145">bug 85145</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=108061" name="attach_108061" title="fix crash">attachment 108061</a> <a href="attachment.cgi?id=108061&action=edit" title="fix crash">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=85145&attachment=108061'>[review]</a>
fix crash
Review of <span class=""><a href="attachment.cgi?id=108061" name="attach_108061" title="fix crash">attachment 108061</a> <a href="attachment.cgi?id=108061&action=edit" title="fix crash">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=85145&attachment=108061'>[review]</a>:
-----------------------------------------------------------------
::: utils/pdfdetach.cc
@@ +163,5 @@
<span class="quote">> nPages = doc->getCatalog()->getNumPages();
> for (i = 0; i < nPages; ++i) {
> page = doc->getCatalog()->getPage(i + 1);
> + if (!page)
> + break;</span >
LGTM, I guess we can assume that if a page is NULL here, all others will be
invalid as well, since this could only happen in case of invalid documents,
right?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>