<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - reproducible crash with some PDF files"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84555">bug 84555</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - reproducible crash with some PDF files"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84555#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - reproducible crash with some PDF files"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84555">bug 84555</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to Jason Crain from <a href="show_bug.cgi?id=84555#c6">comment #6</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=111069" name="attach_111069" title="Move array reallocation from visitLine to startLine">attachment 111069</a> <a href="attachment.cgi?id=111069&action=edit" title="Move array reallocation from visitLine to startLine">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=84555&attachment=111069'>[review]</a> [review]
> Move array reallocation from visitLine to startLine
>
> If TextSelectionDumper finds exactly 257 lines of text (or probably also
> 513, 1025, etc) it will write past the end of the lines array without
> triggering a reallocation.
>
> Attached patch moves the array size check into
> TextSelectionDumper::finishLine so it's always run when an item is added to
> the lines array.</span >
Good catch! I've just pushed it, thanks!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>