<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [patch] fix "length bigger than vheaTab size" and "length bigger than vmtxTab size""
href="https://bugs.freedesktop.org/show_bug.cgi?id=89076#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [patch] fix "length bigger than vheaTab size" and "length bigger than vmtxTab size""
href="https://bugs.freedesktop.org/show_bug.cgi?id=89076">bug 89076</a>
from <span class="vcard"><a class="email" href="mailto:ajohnson@redneon.com" title="Adrian Johnson <ajohnson@redneon.com>"> <span class="fn">Adrian Johnson</span></a>
</span></b>
<pre>These three changes are unrelated and should be split into three separate
commits.
My only concern with the alloca change is ensuring the stack usage is not too
large.
<span class="quote">> argsSize = 8;
> +#if HAVE_ALLOCA_H
> + args = (GooStringFormatArg *)alloca(argsSize * sizeof(GooStringFormatArg));
> +#else</span >
This is a fixed size allocation that I estimate to be up to 544 bytes so it
should be fine.
<span class="quote">> argsSize *= 2;
> +#if HAVE_ALLOCA_H
> + {
> + GooStringFormatArg *new_args = (GooStringFormatArg
> *)alloca(argsSize * sizeof(GooStringFormatArg));
> + memcpy(new_args, args, argsLen);
> + args = new_args;
> + }
> +#else</span >
It looks like the allocation is increased if there are more than 8 format args.
I have not searched the code to see if there are more than 8 format args used.
I'm guessing this is unlikely so maybe when there are more than 8 args we could
fallback to using gmallocn/greallocn. If > 8 args is rare there will be little
performance impact but it does put an upper bound on the stack usage.
<span class="quote">> +#if HAVE_ALLOCA_H
> +#else
> gfree(args);
> +#endif</span >
#ifndef HAVE_ALLOCA_H
gfree(args);
#endif
would be better.
<span class="quote">> +#if 0
> int FlateStream::getChar() {
> if (pred) {
> return pred->getChar();
> }
> return doGetRawChar();
> }
> +#endif</span >
I don't see any need for keeping this. It will always be in the git history.
I had trouble understanding what the timings you provided are referring to.
Could you provide separate times for master, master + alloca change, and master
+ alloc + inline change.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>