<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [patch] inline some frequently called stream functions" href="https://bugs.freedesktop.org/show_bug.cgi?id=89097#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [patch] inline some frequently called stream functions" href="https://bugs.freedesktop.org/show_bug.cgi?id=89097">bug 89097</a> from <a class="email" href="mailto:williambader@hotmail.com" title="William Bader <williambader@hotmail.com>"> William Bader</a> <pre>OK. It didn't seem to make much of a performance difference since the getChar() functions are virtual and can't be inlined. I think that a better solution is making the low-level Stream interface based on filling buffers rather than passing characters one at a time. The profile above has 111M calls to one of the getChar() functions. Would it be possible to have only one non-virtual getChar() in Stream that calls a virtual function to fill a buffer as needed? At worst the buffer fill function could just load the one character that getChar() would have returned, so it would not require a redesign of streams that can provide only one character at a time.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>