<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Memory leak with duplicate font" href="https://bugs.freedesktop.org/show_bug.cgi?id=89952#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Memory leak with duplicate font" href="https://bugs.freedesktop.org/show_bug.cgi?id=89952">bug 89952</a> from <a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> Carlos Garcia Campos</a> <pre>Comment on <a href="attachment.cgi?id=114947" name="attach_114947" title="Free font data when we find duplicate">attachment 114947</a> <a href="attachment.cgi?id=114947&action=edit" title="Free font data when we find duplicate">[details]</a> <a href='page.cgi?id=splinter.html&bug=89952&attachment=114947'>[review]</a> Free font data when we find duplicate Review of <a href="attachment.cgi?id=114947" name="attach_114947" title="Free font data when we find duplicate">attachment 114947</a> <a href="attachment.cgi?id=114947&action=edit" title="Free font data when we find duplicate">[details]</a> <a href='page.cgi?id=splinter.html&bug=89952&attachment=114947'>[review]</a>: ----------------------------------------------------------------- The commit message is a bit confusing, this only happens when _ft_new_face is called with font_data + font_data_len (embedded fonts). I wonder if we should release that data in more cases, because _ft_done_face is assuming the data is mmaped. So, for example, when FT_New_Memory_Face fails, we should also free the data? Should we check in _ft_done_face if data->fd is -1 to do the unmap ro gfree? I'm confused, because _ft_done_face should fail for embedded fonts, or it's simply never called due to the cairo cache being always alive.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>