<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Memory Leak in CairoFreeTypeFont::create"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89952#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Memory Leak in CairoFreeTypeFont::create"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89952">bug 89952</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to Jason Crain from <a href="show_bug.cgi?id=89952#c5">comment #5</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=114973" name="attach_114973" title="Fix memory leak in CairoFreeTypeFont::create">attachment 114973</a> <a href="attachment.cgi?id=114973&action=edit" title="Fix memory leak in CairoFreeTypeFont::create">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=89952&attachment=114973'>[review]</a> [review]
> Fix memory leak in CairoFreeTypeFont::create
>
> I was hoping it would be less confusing as separate patches. :)</span >
And confused me :-P
<span class="quote">> I've squashed the patches. This frees things in three places:
>
> - In _ft_done_face, free the embedded font data.
> - In _ft_new_face, free the embedded font data if it's found to be a
> duplicate.</span >
You should also free the bytes in _ft_new_face when FT_New_Memory_Face fails,
no?
<span class="quote">> - In CairoFreeTypeFont::create, free the embedded font data and codeToGID
> array if font creation fails.</span >
Good catch! This one is probably more unrelated and could be in a separate
patch, but I'm fine with a single patch too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>