<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Annotations of /Subtype /Popup are not added to /Annots array of a page"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89136#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Annotations of /Subtype /Popup are not added to /Annots array of a page"
href="https://bugs.freedesktop.org/show_bug.cgi?id=89136">bug 89136</a>
from <span class="vcard"><a class="email" href="mailto:philipp.reinkemeier@offis.de" title="philipp.reinkemeier@offis.de">philipp.reinkemeier@offis.de</a>
</span></b>
<pre>(In reply to Carlos Garcia Campos from <a href="show_bug.cgi?id=89136#c14">comment #14</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=113520" name="attach_113520" title="Add annotation of Subtype Popup to pdf page">attachment 113520</a> <a href="attachment.cgi?id=113520&action=edit" title="Add annotation of Subtype Popup to pdf page">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=89136&attachment=113520'>[review]</a> [review]
> Add annotation of Subtype Popup to pdf page
>
> Review of <span class=""><a href="attachment.cgi?id=113520" name="attach_113520" title="Add annotation of Subtype Popup to pdf page">attachment 113520</a> <a href="attachment.cgi?id=113520&action=edit" title="Add annotation of Subtype Popup to pdf page">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=89136&attachment=113520'>[review]</a> [review]:
> -----------------------------------------------------------------
>
> ::: poppler/Page.cc
> @@ +450,5 @@
> > + AnnotMarkup *annot_markup = dynamic_cast<AnnotMarkup*>(annot);
> > + if (annot_markup) {
> > + AnnotPopup *annot_popup = annot_markup->getPopup();
> > + if (annot_popup) {
> > + this->addAnnot(annot_popup);
>
> So, this makes me wonder, should we also remove the popup associated to a
> markup annotation in Page::removeAnnot() when a markup annot is given?</span >
Fortunately this does already happen. Method Page::removeAnnot(Annot *annot)
calls annot->removeReferencedObjects(). This in turn is virtual and
AnnotMarkup::removeReferencedObjects() calls Page::removeAnnot() again, this
time with its AnnotPopup.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>