<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - pdfunite: embedded files discarded during merge" href="https://bugs.freedesktop.org/show_bug.cgi?id=90066#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - pdfunite: embedded files discarded during merge" href="https://bugs.freedesktop.org/show_bug.cgi?id=90066">bug 90066</a> from <a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> Thomas Freitag</a> <pre>(In reply to Jason Crain from <a href="show_bug.cgi?id=90066#c7">comment #7</a>) Thanks for reviewing. I hadn't done a memory leak check, sorry, normally I do that. The next patch will remove the memory leaks. BUT: > @@ +249,5 @@ > > } > > + catDict->lookup("Names", &names); > > + if (!names.isNull() && names.isDict()) { > > + docs[0]->markPageObjects(names.getDict(), yRef, countRef, 0, refPage->num, refPage->num); > > + } > > You are processing the first document twice, first here and again below. That's not true. The problem is probably the name "markPageObjects". But the first parameter is a dictionary, so probably a better name for this method should be markDictObjects. So here it marks every object referenced by the "Names"-dict in the catalog dict, and this is the only place where markPageObjects is called with it (in doMergeNameTree it will be called for the "Names"-dict of the othere pages!). The name for the method "markPageObjects" has historical reasons. When I developped it first it was just called with the page dictionary!</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>