<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:lztoad@gmail.com" title="Dmytro Morgun <lztoad@gmail.com>"> <span class="fn">Dmytro Morgun</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - poppler GlobalParamsWin bug/fixes"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91053">bug 91053</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>lztoad@gmail.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - poppler GlobalParamsWin bug/fixes"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91053#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - poppler GlobalParamsWin bug/fixes"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91053">bug 91053</a>
from <span class="vcard"><a class="email" href="mailto:lztoad@gmail.com" title="Dmytro Morgun <lztoad@gmail.com>"> <span class="fn">Dmytro Morgun</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=116647" name="attach_116647" title="patch for poppler/GlobalParamsWin.cc">attachment 116647</a> <a href="attachment.cgi?id=116647&action=edit" title="patch for poppler/GlobalParamsWin.cc">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=91053&attachment=116647'>[review]</a>
patch for poppler/GlobalParamsWin.cc
Uhm, I don't really know what to write. The first one in a patch is major and
can cause crash (I've encountered it). See
<a href="http://cgit.freedesktop.org/poppler/poppler/tree/poppler/GlobalParamsWin.cc">http://cgit.freedesktop.org/poppler/poppler/tree/poppler/GlobalParamsWin.cc</a>
line 447 and compare it to
<a href="http://cgit.freedesktop.org/poppler/poppler/tree/poppler/GlobalParams.cc">http://cgit.freedesktop.org/poppler/poppler/tree/poppler/GlobalParams.cc</a> line
1398. The latter is how it should be for windows.
The second is patch for GooString that was never freed.
The third is too a GooString that was never freed sometimes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>