<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [patch] Allow disabling C assertions with configure --disable-assert" href="https://bugs.freedesktop.org/show_bug.cgi?id=90796#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [patch] Allow disabling C assertions with configure --disable-assert" href="https://bugs.freedesktop.org/show_bug.cgi?id=90796">bug 90796</a> from <a class="email" href="mailto:williambader@hotmail.com" title="William Bader <williambader@hotmail.com>"> William Bader</a> <pre>Created <a href="attachment.cgi?id=116815" name="attach_116815" title="revised patch">attachment 116815</a> <a href="attachment.cgi?id=116815&action=edit" title="revised patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=90796&attachment=116815'>[review]</a> revised patch This patch creates a ./configure option called --enable-release-mode that adds-O2 -DNDEBUG to CFLAGS and CXXFLAGS just like the options in cmake/modules/PopplerMacros.cmake that are enabled by cmake -DCMAKE_BUILD_TYPE=Release. $ grep -i release cmake/modules/PopplerMacros.cmake set(CMAKE_CXX_FLAGS_RELEASE "-O2 -DNDEBUG") set(CMAKE_C_FLAGS_RELEASE "-O2 -DNDEBUG") set(CMAKE_CXX_FLAGS_RELEASE "-O2 -DNDEBUG") set(CMAKE_C_FLAGS_RELEASE "-O2 -DNDEBUG") Is that better? It creates a configure option with a name similar to the cmake option that adds the same flags as the cmake option.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>