<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [patch] shlobj.h is missing #defines without including windows.h first"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=91384">91384</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>[patch] shlobj.h is missing #defines without including windows.h first
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>poppler
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Windows (All)
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>general
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>poppler-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>drawoc@darkrefraction.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=117232" name="attach_117232" title="Patch to fix including shlobj.h">attachment 117232</a> <a href="attachment.cgi?id=117232&action=edit" title="Patch to fix including shlobj.h">[details]</a></span>
Patch to fix including shlobj.h

When cross-compiling poppler for windows using mingw, I get the following
error:

In file included from GlobalParams.cc:59:0:
/usr/i686-w64-mingw32/include/shlobj.h:37:3: error: 'EXTERN_C' does not name a
type
   SHFOLDERAPI SHGetFolderPathW (HWND hwnd, int csidl, HANDLE hToken, DWORD
dwFlags, LPWSTR pszPath);
   ^

It seems that simply including windows.h before shlobj.h pulls in the necessary
definitions for shlobj.h and fixes this issue. See attached patch.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>