<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - pdfunite: embedded files discarded during merge"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90066#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - pdfunite: embedded files discarded during merge"
href="https://bugs.freedesktop.org/show_bug.cgi?id=90066">bug 90066</a>
from <span class="vcard"><a class="email" href="mailto:Thomas.Freitag@alfa.de" title="Thomas Freitag <Thomas.Freitag@alfa.de>"> <span class="fn">Thomas Freitag</span></a>
</span></b>
<pre>(In reply to Albert Astals Cid from <a href="show_bug.cgi?id=90066#c11">comment #11</a>)
<span class="quote">> Thomas, don't
> GooString *newKey = new GooString("Names");
> and
> GooString *newKey = new GooString(key);
>
> leak too?</span >
Sorry for the delay. I just looked into it again, and yes, in case of keys in a
Dict the choice of "new GooString" is definitely wrong, it could not cause only
a memory leak, in case of the static version of GooString it could also cause
memory corruption. I have to use copyString in this cases. I wonder a little
bit why valgrind didn't show me that problem.
I will upload a new patch in a few minutes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>