<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [RFC PATCH] Complete support for transition effect durations (they can be fractional)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92040#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [RFC PATCH] Complete support for transition effect durations (they can be fractional)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92040">bug 92040</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to Arseniy Lartsev from <a href="show_bug.cgi?id=92040#c6">comment #6</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=120275" name="attach_120275" title="Non-integer transition durations for poppler-glib">attachment 120275</a> <a href="attachment.cgi?id=120275&action=edit" title="Non-integer transition durations for poppler-glib">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=92040&attachment=120275'>[review]</a> [review]
> Non-integer transition durations for poppler-glib
>
> (In reply to Carlos Garcia Campos from <a href="show_bug.cgi?id=92040#c5">comment #5</a>)
>
> > Thanks for the patch. What does Ex stand for? I don't think we need a new
> > boxed type for this. I think that as long as we don't change the order of
> > the struct members, we can append a new one without breaking api/abi. So, I
> > would just add gdouble duration_float to the existing struct.
>
> Right, people are not supposed to create instances of the structure by
> direct malloc, are they.</span >
Right, those are always allocated by poppler. It's unfortunate that those
struct are public, but still.
<span class="quote">> This is what happens when a KDE user starts hacking
> on GObject stuff :) </span >
:-)
<span class="quote">> Here's a new patch (I called in duration_real to be
> consistent with the already existing counterpart in the Qt wrapper, and also
> because "float" might be confusing whet the type is double).</span >
OK, sounds good to me. Thanks.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>