<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [RFC PATCH] Complete support for transition effect durations (they can be fractional)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92040#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [RFC PATCH] Complete support for transition effect durations (they can be fractional)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92040">bug 92040</a>
from <span class="vcard"><a class="email" href="mailto:carlosgc@gnome.org" title="Carlos Garcia Campos <carlosgc@gnome.org>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=118362" name="attach_118362" title="The patch">attachment 118362</a> <a href="attachment.cgi?id=118362&action=edit" title="The patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=92040&attachment=118362'>[review]</a>
The patch
Review of <span class=""><a href="attachment.cgi?id=118362" name="attach_118362" title="The patch">attachment 118362</a> <a href="attachment.cgi?id=118362&action=edit" title="The patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=92040&attachment=118362'>[review]</a>:
-----------------------------------------------------------------
::: glib/poppler-page.h
@@ +341,5 @@
<span class="quote">> + gdouble duration;
> + gint angle;
> + gdouble scale;
> + gboolean rectangular;
> +};</span >
Thanks for the patch. What does Ex stand for? I don't think we need a new boxed
type for this. I think that as long as we don't change the order of the struct
members, we can append a new one without breaking api/abi. So, I would just add
gdouble duration_float to the existing struct.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>