<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Poppler fails to display pdf correctly" href="https://bugs.freedesktop.org/show_bug.cgi?id=93299#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Poppler fails to display pdf correctly" href="https://bugs.freedesktop.org/show_bug.cgi?id=93299">bug 93299</a> from <a class="email" href="mailto:jason@aquaticape.us" title="Jason Crain <jason@aquaticape.us>"> Jason Crain</a> <pre>Created <a href="attachment.cgi?id=121099" name="attach_121099" title="example rendering">attachment 121099</a> <a href="attachment.cgi?id=121099&action=edit" title="example rendering">[details]</a> example rendering (In reply to Albert Astals Cid from <a href="show_bug.cgi?id=93299#c6">comment #6</a>) > I'm a bit hesitant on the ifdef for ICU, makes it for hard testing for the > two codepaths. How much does it actually improve things? You would prefer ICU be a mandatory dependency? Or hesitant on having ICU be a dependency at all? Completely removing the block of ICU/FcCharSet code, the majority of the text in this PDF (and a couple others I found) is probably going to be missing because there's a good chance that fontconfig is going to choose a font without Cyrillic glyphs. If I keep the FcCharSet code but remove the ICU IsAlphabetic check, some documents will have regressions as fontconfig chooses different fonts. Most of the differences are benign, replacing a font with another similar font, but some are not. Examples in the attached image. * <a href="http://www.epson.com/cmc_upload/0/000/044/561/10000XL_CatSheet.pdf">http://www.epson.com/cmc_upload/0/000/044/561/10000XL_CatSheet.pdf</a> * <a href="http://upload.wikimedia.org/wikipedia/de/7/77/Wikipedia_2005_Inlaycard_small.pdf">http://upload.wikimedia.org/wikipedia/de/7/77/Wikipedia_2005_Inlaycard_small.pdf</a> Light font is replaced with a regular font because the light variant is missing some symbols like bullet, trademark, notequal, and others that are in the default encodings. * <a href="https://www.ftb.ca.gov/forms/2013/13_540.pdf">https://www.ftb.ca.gov/forms/2013/13_540.pdf</a> - numbers along the bottom of the page * <a href="http://bugs.ghostscript.com/attachment.cgi?id=7435">http://bugs.ghostscript.com/attachment.cgi?id=7435</a> - ACPIspec40a.pdf - code samples such as top of page 32 6 And a few other documents. First choice font is missing a euro symbol so fontconfig picks a bold oblique font. I'm starting to suspect this is a fontconfig bug because there are non-bold non-oblique fonts available further down the substitution list. * <a href="http://acroeng.adobe.com/Test_Files/weblinks/Links_Bookmarks/FinalLinkTest.pdf">http://acroeng.adobe.com/Test_Files/weblinks/Links_Bookmarks/FinalLinkTest.pdf</a> On page 3, a Bookman font is replaced with a sans-serif font because it's missing some math symbols. If those aren't a problem I can do a simpler check, skip ICU/IsAlphabetic and only filter out Unicode private use area characters. Or if it is a problem but you don't want to add ICU for something relatively simple like this, make my own blacklist of certain characters. That might be better anyway because I think the ligatures (ff ffi ffl) are also causing some minor oddities and those are still alphabetic letters.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>