[poppler] [PATCH] proper implementation of drawImageMask and enable type3 fonts

Kristian Høgsberg krh at bitplanet.net
Fri Mar 11 15:00:01 PST 2005


Martin Kretzschmar wrote:
> Hi,
> 
> Am Freitag, den 11.03.2005, 17:00 -0500 schrieb Kristian Høgsberg:
> 
>>Jeff Muizelaar wrote:
>>
>>>This patch replaces the older type3 font/imageMask patch. This time we
>>>do imageMask drawing properly.
>>
>>Committed as is.  Jeff, would it be possible for you to provide a 
>>smaller test PDF that use the ImageMask operator?  I think the one you 
>>mentioned in irc used that cairo test image (romedalen.png).  I'd like 
>>to add a smaller test PDF to CVS and use that as a first test case in a 
>>test suite.
> 
> AFAIR http://bugzilla.gnome.org/attachment.cgi?id=19867&action=view uses
> ImageMask (in Type 3 fonts). 
> 
> You can use a command like this 
> 
> 	pdftk original cat 1-1 output /tmp/page-1.pdf
> 
> to extract a single page and get a smaller file.

Thanks, that's useful, and that PDF looks like an interesting case 
(what's the bug number, btw?)  However, for the poppler test suite, I 
was thinking of creating a number of tiny PDF files designed to exercise 
specific code paths in xpdf.  Jeff mentioned this:

   infidigm.net/~jeff/mask.pdf

in IRC the other day, and that looks like something Jeff made 
specifically to test the ImageMask code path.  Ideally, when we change 
xpdf internals we should make a test case that use the affected PDF 
operators and render a reference image before doing the change.  When 
the change is implemented, we can test for regressions by comparing the 
new output to the reference image.  I'd like to do the same for the 
libjpeg change that I recently committed.

cheers,
Kristian


More information about the poppler mailing list