[poppler] poppler/glib: poppler-document.cc, 1.13, 1.14 poppler-document.h, 1.9, 1.10

Kristian Høgsberg krh at bitplanet.net
Sat May 21 14:32:06 PDT 2005


On Sat, 2005-05-21 at 14:47 +0200, Juerg Billeter wrote:
> > +	ps_file->out = new PSOutputDev ((char *)filename,
> > +					document->doc->getXRef(),
> > +					document->doc->getCatalog(),
> > +					first_page + 1,
> > +					first_page + n_pages - 1,
> Shouldn't the "- 1" be omitted here? Verbose it'd be (first_page + 1) +
> n_pages - 1, i.e. first_page + n_pages.

You're right, nice catch.  I've committed your verbose version to remind
us of the differing 0-based/1-based page index conventions.

cheers,
Kristian




More information about the poppler mailing list