[poppler] Glib bindings forms review

[Carlos Garcia Campos]

El jue, 28-06-2007 a las 13:03 +0200, Julien Rebetez escribió:
> Hi,
> Sorry for the response delay.
> I agree with all your points and the patch looks good though I don't 
> have time right now (exams :) ) to test it.

Ok, no problem, I only wanted to make sure you agreed before committing
the changes. 

Good luck with the exams! ;-)

> Regards,
> Julien
> 
> Carlos Garcia Campos wrote:
> > Hi, 
> >
> > I've been reviewing forms code in the glib bindings and I think that
> > current API is a little bit confusing. Having two different interfaces
> > (PopplerDocument and PopplerFormfield) for handling forms doesn't look
> > natural to me. So, I propose to use only one interface based on
> > PopplerFormField. Instead of create structures to pass forms information
> > to the frontends, we can just use an opaque object, like poppler-page,
> > that wraps FormWidget. This object has methods for both getting and
> > setting. Finally, in PopplerDocument we only need one method to be able
> > to get a PopplerFormField from its id. 
> >
> > In addition, I suggest to use a PopplerFormFieldMapping, instead of
> > including the coords information in the FormField object, for
> > consistency with the current API (links and images). 
> >
> > Here is a patch that implements these suggestions:
> >
> > http://people.freedesktop.org/~carlosgc/poppler-glib-forms.diff
> >
> > what do you guys think? Julien?
> >
> >   
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > poppler mailing list
> > poppler at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/poppler
> >   
> 
-- 
Carlos Garcia Campos
   elkalmail at yahoo.es
   carlosgc at gnome.org
   http://carlosgc.linups.org
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada
	digitalmente
Url : http://lists.freedesktop.org/archives/poppler/attachments/20070628/2ef2dd3e/attachment.pgp